-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #5201 Relicense under the Apache 2.0 and add header to source files #5783
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, and thank you for opening this PR! 🎉
All contributors have signed the CLA, thank you! ❤️
Have an awesome day! ☀️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Copyright EPFL.
I think we should do Copyright EPFL and Lightbend, Inc.
like scala/scala, if only because some of our source code comes from scala/scala.
@dwijnand there's supposed to be a e.g. https://github.com/scala/scala/blob/2.13.x/NOTICE |
Correct, http://www.apache.org/dev/apply-license.html#new:
I'd recommend:
|
Here is an updated header, following scala/scala's example:
For the
|
Yes, I think so. So far we've used https://github.com/lampepfl/dotty/blob/master/AUTHORS.md for this. |
The license field in https://github.com/lampepfl/dotty/blob/master/vscode-dotty/package.json will also need to be updated. |
Following the recommendation of the Apache Software Foundation: http://apache.org/dev/apply-license.html#license-file-name
Changed to be coherent with the NOTICE and source file headers.
Can we avoid adding the header to every file? |
Unclear, but at this point scala/scala has already added the header everywhere so to be consistent we need to do the same anyway. |
|
So I guess we could also we just write "Unless stated otherwise, every |
There's an sbt plugin for maintaining file headers like this, IIRC.
…On Fri, Mar 1, 2019, 8:18 AM Olivier Blanvillain ***@***.***> wrote:
SHOULD
So I guess we could also we just write "Unless stated otherwise, every
.scala file in this repository is distributed under the Apache License
2.0." or something. I find it crazy that we can use all these elaborate
programming abstractions but we have to copy paste a bunch a boilerplate
everywhere for licencing...
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#5783 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAGAUCz7WpdF4oixU7rI9aEoL8ru8Trxks5vSSjAgaJpZM4aO5Qz>
.
|
That plugin is in fact used in this PR :). |
Sorry. Then I didn't understand @OlivierBlanvillain's comment. |
I'm not concerned about maintenance, what bothers me is having 10 useless lines at the beginning of every single file. Maybe I need an ad blocker in my text editor or something 😋 |
IANAL etc, but I think it would be equally valid (and much shorter) for the header to be
|
I think IntelliJ folds things like that by default...
…On Fri, Mar 1, 2019, 4:17 PM Olivier Blanvillain ***@***.***> wrote:
I'm not concerned about maintenance, what bothers me is having 10 useless
lines at the beginning of every single file. Maybe I need an ad blocker in
my text editor or something 😋
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#5783 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAGAUHQGQG3dRDQgd93KByfDVn_T94A3ks5vSZjxgaJpZM4aO5Qz>
.
|
previous round of bikeshedding on this at |
We have to agree on something if we don't want this PR to rot forever. Do we want to merge the current state or reduce the size of the header first? |
We should do exactly what Scala 2 does so keep the current header, anything else will make code sharing harder for no good reason. |
May I suggest that it's time to revive or replace this PR? The core of it — replacing BSD license with Apache license — seems crucially important to me. |
Feel free to open a new updated pr. |
more minimal PR that doesn't do anything with the headers: #8026 |
This PR addresses issue #5201 by relicensing the project to Apache 2.0 and adding the following license header to every scala source file:
I didn't use the default license header for Apache 2.0 as both scala and scala-js already use a condensed version.